From 1306bf7c504cce3dc0b6f3e99b1434f206eea67d Mon Sep 17 00:00:00 2001
From: Simon Leipold <s.leipold@adito.de>
Date: Thu, 8 Aug 2019 13:31:17 +0200
Subject: [PATCH] Permissions - extended onValidation to block null-actions
---
entity/PermissionAction_entity/onValidation.js | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/entity/PermissionAction_entity/onValidation.js b/entity/PermissionAction_entity/onValidation.js
index 47c7fa0352..ea8413e93c 100644
--- a/entity/PermissionAction_entity/onValidation.js
+++ b/entity/PermissionAction_entity/onValidation.js
@@ -10,7 +10,9 @@ var actionTitle = vars.get("$field.ACTION");
var permissionId = vars.get("$param.PermissionId_param");
var permCondInput = vars.get("$param.PermissionCondition_param");
-if (PermissionUtil.existsPermission(permissionId)) {
+if (actionTitle == "null" || actionTitle == undefined || actionTitle == null || actionTitle == "") {
+ result.string(translate.text("Empty actions are not allowed!"));
+} else if (PermissionUtil.existsPermission(permissionId)) {
// existing permission
// check if action is already in DB
var actionsInDb = PermissionUtil.getPermissionAction(permissionId);
@@ -23,4 +25,6 @@ if (PermissionUtil.existsPermission(permissionId)) {
break;
}
}
+} else {
+ result.string(true);
}
\ No newline at end of file
--
GitLab