From 78f8889fd3570ac2237c252c046dfdf5f8640218 Mon Sep 17 00:00:00 2001
From: Simon Leipold <s.leipold@adito.de>
Date: Mon, 12 Aug 2019 15:54:38 +0200
Subject: [PATCH] Permissions - bugfix: blocking permissions without actions
 now

---
 .../entityfields/permissionactions/onValidation.js         | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/entity/PermissionDetail_entity/entityfields/permissionactions/onValidation.js b/entity/PermissionDetail_entity/entityfields/permissionactions/onValidation.js
index b726986dd84..9822dae1407 100644
--- a/entity/PermissionDetail_entity/entityfields/permissionactions/onValidation.js
+++ b/entity/PermissionDetail_entity/entityfields/permissionactions/onValidation.js
@@ -17,16 +17,19 @@ var permCondInput = vars.get("$field.CONDITION");
 var permCondType = vars.get("$field.CONDTYPE");
 var permissionId = PermissionUtil.getPermission(roleTitle, entityTitle, fieldTitle, accesstype, permCondInput, permCondType);
 var actionsInDb = PermissionUtil.getActions([permissionId]);
-
 var actionsAsStringArray = vars.get("$field.ACTION").split(","); // only useful while working with already existing permissions
 
 var deletedRows = vars.get("$field.PermissionActions.deletedRows");
 var changedRows = vars.get("$field.PermissionActions.changedRows");
 var insertedRows = vars.get("$field.PermissionActions.insertedRows");
 
+if (deletedRows.length == actionsAsStringArray.length && changedRows.length == 0 && insertedRows.length == 0) {
+    result.string(translate.text("Permissions without actions are not allowed!"));
+}
+
 if (PermissionUtil.permissionExists(permissionId)) {
     // old permission
-    // insert nur möglich, wenn gleiche action auch gelöscht wurde, oder zuvor nicht da war
+    // insert only possible, if the same action is not already linked to the permission
     for each (let row in insertedRows) {
         var actionGotJustDelted = false;
         if (PermissionUtil.actionExists(row.ACTION, permissionId)) {
-- 
GitLab