From ea11370b98481cbe5f2ba768aa8592ab980b9a78 Mon Sep 17 00:00:00 2001
From: Johannes Hoermann <j.hoermann@adito.de>
Date: Thu, 17 Oct 2019 16:27:01 +0200
Subject: [PATCH] todo notes added
---
process/Importer_lib/process.js | 2 +-
process/Permission_lib/process.js | 2 +-
process/autostartNeon/process.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/process/Importer_lib/process.js b/process/Importer_lib/process.js
index 91198fba0e6..776241153b4 100644
--- a/process/Importer_lib/process.js
+++ b/process/Importer_lib/process.js
@@ -813,7 +813,7 @@ function Importer(pConfig)
var xmlArr = [];
//get every row-element
- for each(xmlItem in xmlData.data.row)
+ for each(xmlItem in xmlData.data.row) // TODO: replace "for each (.. in ..)" with for (.. of ..) when the designer supports it (the server already supports it). As it's deprecated in js https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Statements/for_each...in
{
xmlArr = [];
diff --git a/process/Permission_lib/process.js b/process/Permission_lib/process.js
index a4f854bfb3a..a7ee9deba6c 100644
--- a/process/Permission_lib/process.js
+++ b/process/Permission_lib/process.js
@@ -596,7 +596,7 @@ function arrDiff (arr1, arr2) {
// checks input array if each element is a valid input, returns true if valid, otherwise false
function checkInput(pInputArr) {
- for each (var input in pInputArr) {
+ for each (var input in pInputArr) { // TODO: replace "for each (.. in ..)" with for (.. of ..) when the designer supports it (the server already supports it). As it's deprecated in js https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Statements/for_each...in
if (input == undefined || input == null || input == "")
return false;
}
diff --git a/process/autostartNeon/process.js b/process/autostartNeon/process.js
index 03e2714f7ed..647faa61ecb 100644
--- a/process/autostartNeon/process.js
+++ b/process/autostartNeon/process.js
@@ -23,7 +23,7 @@ var entitiesUsePermFlagSet = []; // array, which contains ids of entities with u
var roleInternalEveryone = "INTERNAL_EVERYONE";
// gets all names of the entites which have the 'usePermission'-flag set (positive list)
-for each (let entityMetaData in entitiesMetaData) {
+for each (let entityMetaData in entitiesMetaData) { // TODO: replace "for each (.. in ..)" with for (.. of ..) when the designer supports it (the server already supports it). As it's deprecated in js https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Statements/for_each...in
if (entityMetaData[6] == "true") {
entitiesUsePermFlagSet.push(entityMetaData[0])
if (PermissionUtil.getNumberOfPermissions(entityMetaData[0]) == 0) {
--
GitLab