fix of: cancelling in prod2prod (the parts list) raises an error

entity/Prod2prod_entity/recordcontainers/jdito/contentProcess.js

@@ -111,32 +111,33 @@ function buildGraph (elementID, parentElementID, mappingStructure, prod2prodIdMa
     return elements;
 }
 
-if (vars.get("$sys.recordstate") != neon.OPERATINGSTATE_NEW)
-{
-    var prodid = vars.exists("$param.ProductId_param") 
-                 && vars.get("$param.ProductId_param") != null ? vars.get("$param.ProductId_param") : "";
-    if(prodid != "")
-    {
-        // First 3 columns are crucial, the rest is optional.
-        var data = db.table("select PROD2PRODID, SOURCE_ID, DEST_ID, QUANTITY, PRODUCTCODE, PRODUCTID, PROD2PRODID, OPTIONAL, TAKEPRICE "
-                    + "from PROD2PROD join PRODUCT on PROD2PROD.SOURCE_ID = PRODUCTID "
-                    + "order by PRODUCTCODE");
-                
-        var prod2prodIdMapping = buildProd2ProdIDMapping(data);
-        var childrenMapping = buildChildrenMapping(data);
-        var rootElements = calculateRootElements(prodid, data);
-        
-        var allData = []
-        
-        rootElements.forEach(function(rg) {
-            var graphData = buildGraph(rg, null, childrenMapping, prod2prodIdMapping)
-            graphData.forEach(function (gd) { allData.push(gd); })
-        })
-                
-        result.object(allData);
-    }
-}
-else
+/*
+ * in the past at this point a check for the "recordstate" was done
+ * this should not be necessery and in fact causes a problem:
+ * When adding a new prod2prod entry and performing a cancel an error is raised that the variable does not exist.
+ * 
+ * So *IF* you need that check for the state, you should check if this error is thrown 
+ * + add a comment why the check is needed here instead of this current comment
+ */
+var prodid = vars.exists("$param.ProductId_param") 
+             && vars.get("$param.ProductId_param") != null ? vars.get("$param.ProductId_param") : "";
+if(prodid != "")
 {
-    result.object([]);
-}
+    // First 3 columns are crucial, the rest is optional.
+    var data = db.table("select PROD2PRODID, SOURCE_ID, DEST_ID, QUANTITY, PRODUCTCODE, PRODUCTID, PROD2PRODID, OPTIONAL, TAKEPRICE "
+                + "from PROD2PROD join PRODUCT on PROD2PROD.SOURCE_ID = PRODUCTID "
+                + "order by PRODUCTCODE");
+
+    var prod2prodIdMapping = buildProd2ProdIDMapping(data);
+    var childrenMapping = buildChildrenMapping(data);
+    var rootElements = calculateRootElements(prodid, data);
+
+    var allData = []
+
+    rootElements.forEach(function(rg) {
+        var graphData = buildGraph(rg, null, childrenMapping, prod2prodIdMapping)
+        graphData.forEach(function (gd) { allData.push(gd); })
+    })
+
+    result.object(allData);
+}
\ No newline at end of file