refactor value processes: use this.value

entity/Activity_entity/entityfields/moduletrees/children/id/valueProcess.js

-import("system.result");
-import("system.vars");
-
-result.string(vars.get("$field.ACTIVITYID"));
\ No newline at end of file

entity/Appointment_entity/entityfields/summary/valueProcess.js

@@ -6,7 +6,7 @@ import("system.result");
 /**
  * Following if() is only for passing param-parts from "new Appointment"-Dialog to AppointmentEditViewTemplate
  */
-if(vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW && vars.exists("$param.Entry_param") && !vars.get("$field.SUMMARY"))
+if(vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW && vars.exists("$param.Entry_param") && vars.get("$this.value") == null)
 {
     var event = JSON.parse(vars.getString("$param.Entry_param"));
 
@@ -14,4 +14,4 @@ if(vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW && vars.exists("$para
         result.string(event[calendars.SUMMARY]);
 }
 else
-    result.string(vars.get("$field.SUMMARY"));
\ No newline at end of file
+    result.string(vars.get("$this.value"));
\ No newline at end of file

entity/Appointment_entity/entityfields/uid/valueProcess.js

@@ -2,7 +2,7 @@ import("system.vars");
 import("system.result");
 import("system.util");
 
-if(!(vars.get("$field.UID")))
+if(!(vars.get("$this.value")))
     result.string(util.getNewUUID());
 else
-    result.string(vars.get("$field.UID"));
\ No newline at end of file
+    result.string(vars.get("$this.value"));
\ No newline at end of file

entity/AttributeUsage_entity/entityfields/ab_attribute_id/valueProcess.js

-import("system.vars");
-import("system.result");
-import("system.neon");
-
-if (vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW && vars.exists("$param.AttributeId_param") && vars.get("$param.AttributeId_param") != null)
-    result.string(vars.get("$param.AttributeId_param"));
-else if (vars.get("$field.AB_ATTRIBUTE_ID"))
-    result.string(vars.get("$field.AB_ATTRIBUTE_ID"));
\ No newline at end of file
+import("system.vars");
+import("system.result");
+import("system.neon");
+
+if (vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW && vars.exists("$param.AttributeId_param") && vars.get("$param.AttributeId_param") != null)
+    result.string(vars.get("$param.AttributeId_param"));
+else if (vars.get("$this.value"))
+    result.string(vars.get("$this.value"));
\ No newline at end of file

entity/Attribute_entity/entityfields/full_attribute_name/valueProcess.js

-import("system.vars");
-import("system.result");
-import("Attribute_lib");
-
-var name = vars.get("$field.ATTRIBUTE_NAME");
-if (!(vars.exists("$param.DisplaySimpleName_param") && vars.get("$param.DisplaySimpleName_param")))
-{
-    var parentName = AttributeUtil.getFullAttributeName(vars.get("$field.ATTRIBUTE_PARENT_ID"));
-    name = (parentName ? parentName + " / " : "") + name;
-}
+import("system.vars");
+import("system.result");
+import("Attribute_lib");
+
+var name = vars.get("$this.value");
+if (!(vars.exists("$param.DisplaySimpleName_param") && vars.get("$param.DisplaySimpleName_param")))
+{
+    var parentName = AttributeUtil.getFullAttributeName(vars.get("$field.ATTRIBUTE_PARENT_ID"));
+    name = (parentName ? parentName + " / " : "") + name;
+}
 result.string(name);
\ No newline at end of file

entity/Contact_entity/entityfields/address_id/valueProcess.js

@@ -3,7 +3,7 @@ import("system.vars");
 import("StandardObject_lib");
 
 //  Check if the standard address is already set.
-if (vars.get("$field.ADDRESS_ID") === null || vars.get("$field.ADDRESS_ID") === "" || vars.get("$field.ADDRESS_ID") == 0) {
+if (vars.get("$this.value") === null || vars.get("$this.value") === "" || vars.get("$this.value") == 0) {
     var possibleStandardAddressID = new StandardObject("Address", null, "Person", vars.get("$field.CONTACTID"))
         .onPersonValueChange(vars.get("$field.ORGANISATION_ID"));
 

entity/DuplicateScanConditionConfig_entity/entityfields/condition/valueProcess.js

@@ -2,8 +2,8 @@ import("system.logging");
 import("system.vars");
 import("system.result");
 
-logging.log("condition -> " + JSON.stringify(vars.get("$field.CONDITION")));
-if(vars.get("$field.CONDITION") == "")
+logging.log("condition -> " + JSON.stringify(vars.get("$this.value")));
+if(vars.get("$this.value") == "")
 {
     let entityToScan = vars.get("$param.EntityToFilter_param");
     logging.log("condition leer neu rein schreiben -> " + entityToScan);

entity/DuplicateScanConditionConfig_entity/entityfields/duplicatescan_id/valueProcess.js

 import("system.result");
 import("system.vars");
-if(vars.get("$field.DUPLICATESCAN_ID") == "")
+if(vars.get("$this.value") == "")
 {
     result.string(vars.get("$param.DuplicateScanId_param"));
 }
\ No newline at end of file

entity/Offer_entity/entityfields/header/valueProcess.js

@@ -3,6 +3,7 @@ import("system.vars");
 import("system.neon");
 import("system.db");
 import("system.util");
+import("Sql_lib");
 
 if(vars.exists("$param.OfferHeader_param") && vars.get("$param.OfferHeader_param")) 
     result.string(vars.get("$param.OfferHeader_param"));
@@ -15,6 +16,6 @@ else if(vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW)
 
 if (vars.get("$field.ChoosenTEXHeader") != "")
 {
-    var binaryId      = db.cell("select ID from ASYS_BINARIES where ROW_ID = '" + vars.get("$field.ChoosenTEXHeader") + "'", "_____SYSTEMALIAS");
-    result.string(util.decodeBase64String(db.getBinaryContent(binaryId, "_____SYSTEMALIAS")));
+    var binaryId      = db.cell("select ID from ASYS_BINARIES where ROW_ID = '" + vars.get("$field.ChoosenTEXHeader") + "'", SqlUtils.getSystemAlias());
+    result.string(util.decodeBase64String(db.getBinaryContent(binaryId, SqlUtils.getSystemAlias())));
 }
\ No newline at end of file

entity/PermissionDetail_entity/entityfields/role/valueProcess.js

@@ -8,7 +8,7 @@ var role = "";
 if(vars.exists("$param.RoleTitle_param") && (recordstate == neon.OPERATINGSTATE_NEW)) {
     role = vars.get("$param.RoleTitle_param");
 } else {
-    role = vars.get("$field.ROLE");
+    role = vars.get("$this.value");
 }
 
 result.string(role);
\ No newline at end of file

entity/Person_entity/entityfields/address_id/valueProcess.js

-import("system.result");
-import("system.vars");
-import("StandardObject_lib");
-
-//  Check if the standard address is already set.
-if (!vars.get("$field.ADDRESS_ID")) 
-{
-    var possibleStandardAddressID = new StandardObject("Address", null, "Person", vars.get("$field.PERSONID"))
-        .onPersonValueChange(vars.get("$field.ORGANISATION_ID"));
-
-    // If a possible standard addrss was found it should get applied to the field.
-    if (possibleStandardAddressID)
-        result.string(possibleStandardAddressID);
+import("system.result");
+import("system.vars");
+import("StandardObject_lib");
+
+//  Check if the standard address is already set.
+if (!vars.get("$this.value")) 
+{
+    var possibleStandardAddressID = new StandardObject("Address", null, "Person", vars.get("$field.PERSONID"))
+        .onPersonValueChange(vars.get("$field.ORGANISATION_ID"));
+
+    // If a possible standard addrss was found it should get applied to the field.
+    if (possibleStandardAddressID)
+        result.string(possibleStandardAddressID);
 }
\ No newline at end of file

entity/Prod2prod_entity/entityfields/quantity/valueProcess.js

@@ -2,7 +2,7 @@ import("system.vars");
 import("system.result");
 import("system.neon");
 
-if (vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW && !vars.get("$field.QUANTITY"))
+if (vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW && vars.get("$this.value") == null)
 {
     result.string("1");
 }
\ No newline at end of file