Employee bugfix

entity/Employee_entity/Employee_entity.aod

@@ -31,18 +31,18 @@
       <consumer>Contacts</consumer>
       <linkedContext>Person</linkedContext>
       <mandatory v="true" />
+      <stateProcess>%aditoprj%/entity/Employee_entity/entityfields/contact_id/stateProcess.js</stateProcess>
       <onValidation>%aditoprj%/entity/Employee_entity/entityfields/contact_id/onValidation.js</onValidation>
+      <onValueChange>%aditoprj%/entity/Employee_entity/entityfields/contact_id/onValueChange.js</onValueChange>
     </entityField>
     <entityField>
       <name>FIRSTNAME</name>
       <title>Firstname</title>
-      <valueProcess>%aditoprj%/entity/Employee_entity/entityfields/firstname/valueProcess.js</valueProcess>
     </entityField>
     <entityField>
       <name>LASTNAME</name>
       <title>Lastname</title>
       <mandatory v="false" />
-      <valueProcess>%aditoprj%/entity/Employee_entity/entityfields/lastname/valueProcess.js</valueProcess>
     </entityField>
     <entityField>
       <name>ISACTIVE</name>
@@ -57,7 +57,6 @@
       <mandatory v="true" />
       <possibleItemsProcess>%aditoprj%/entity/Employee_entity/entityfields/email_address/possibleItemsProcess.js</possibleItemsProcess>
       <newItemsAllowed v="true" />
-      <valueProcess>%aditoprj%/entity/Employee_entity/entityfields/email_address/valueProcess.js</valueProcess>
       <onValidation>%aditoprj%/entity/Employee_entity/entityfields/email_address/onValidation.js</onValidation>
     </entityField>
     <entityField>

entity/Employee_entity/entityfields/email_address/valueProcess.js → entity/Employee_entity/entityfields/contact_id/onValueChange.js

+import("Communication_lib");
+import("Entity_lib");
 import("system.result");
 import("system.db");
 import("system.neon");
 import("system.vars");
 import("Sql_lib");
-import("Communication_lib");
 
-var contactId = vars.get("$field.CONTACT_ID");
+var contactId = ProcessHandlingUtils.getOnValidationValue(vars.get("$field.CONTACT_ID"));
 if ((vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW || vars.get("$sys.recordstate") == neon.OPERATINGSTATE_EDIT)
-    && contactId && !vars.get("$field.EMAIL_ADDRESS"))
+    && contactId)
 {
-    var defaultMail = db.cell(SqlCondition.begin()
-        .andPrepare("CONTACT.CONTACTID", contactId)
-        .buildSql("select (" + CommUtil.getStandardSubSqlMail() + ") from CONTACT")
+    var name = db.array(
+        db.ROW, 
+        SqlCondition.begin()
+            .andPrepare("CONTACT.CONTACTID", contactId)
+            .buildSql("select FIRSTNAME, LASTNAME, (" + CommUtil.getStandardSubSqlMail() + ") from PERSON join CONTACT on CONTACT.PERSON_ID = PERSON.PERSONID")
     );
-    result.string(defaultMail);
+    
+    neon.setFieldValues({
+        "$field.FIRSTNAME" : name[0] || "",
+        "$field.LASTNAME" : name[1] || "",
+        "$field.EMAIL_ADDRESS" : name[2] || ""
+    });
 }
\ No newline at end of file

entity/Employee_entity/entityfields/contact_id/stateProcess.js

+import("system.neon");
+import("system.vars");
+import("system.result");
+import("Employee_lib")
+
+if (vars.get("$sys.recordstate") == neon.OPERATINGSTATE_EDIT && EmployeeUtils.hasRelations(vars.get("$field.CONTACT_ID")))
+    result.string(neon.COMPONENTSTATE_READONLY);
\ No newline at end of file

entity/Employee_entity/entityfields/email_address/onValidation.js

-import("system.translate");
-import("system.neon");
+import("Entity_lib");
 import("system.result");
 import("system.vars");
 import("system.tools");
-import("Entity_lib");
+import("system.translate");
 
 var email = ProcessHandlingUtils.getOnValidationValue(vars.get("$field.EMAIL_ADDRESS"));
-if (email != "" && tools.getUsersByAttribute(tools.EMAIL, [email]).length)
-        result.string(translate.text("Email must be unique!"));
\ No newline at end of file
+var isTaken = tools.getUserByAttribute(tools.EMAIL, [email]);
+isTaken = isTaken 
+    ? isTaken[tools.TITLE] != vars.get("$field.TITLE_ORIGINAL")
+    : false;
+if (email && isTaken)
+    result.string(translate.text("Email must be unique!"));
\ No newline at end of file

entity/Employee_entity/entityfields/email_address/possibleItemsProcess.js

@@ -27,4 +27,4 @@ if ((vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW || vars.get("$sys.r
     result.object(addresses);
 }
 else
-    result.object([])
+    result.object([]);

entity/Employee_entity/entityfields/firstname/valueProcess.js

-import("system.result");
-import("system.db");
-import("system.neon");
-import("system.vars");
-import("Sql_lib");
-
-var contactId = vars.get("$field.CONTACT_ID");
-if ((vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW || vars.get("$sys.recordstate") == neon.OPERATINGSTATE_EDIT)
-    && contactId && !vars.get("$field.FIRSTNAME"))
-{
-    var firstname = db.cell(SqlCondition.begin()
-        .andPrepare("CONTACT.CONTACTID", contactId)
-        .buildSql("select FIRSTNAME from PERSON join CONTACT on CONTACT.PERSON_ID = PERSON.PERSONID")
-    );
-    result.string(firstname);
-}
\ No newline at end of file

entity/Employee_entity/entityfields/lastname/valueProcess.js

-import("system.result");
-import("system.db");
-import("system.neon");
-import("system.vars");
-import("Sql_lib");
-
-var contactId = vars.get("$field.CONTACT_ID");
-if ((vars.get("$sys.recordstate") == neon.OPERATINGSTATE_NEW || vars.get("$sys.recordstate") == neon.OPERATINGSTATE_EDIT)
-    && contactId && !vars.get("$field.LASTNAME"))
-{
-    var lastname = db.cell(SqlCondition.begin()
-        .andPrepare("CONTACT.CONTACTID", contactId)
-        .buildSql("select LASTNAME from PERSON join CONTACT on CONTACT.PERSON_ID = PERSON.PERSONID")
-    );
-    result.string(lastname);
-}
\ No newline at end of file

preferences/_____PREFERENCES_PROJECT/_____PREFERENCES_PROJECT.aod

@@ -2,7 +2,7 @@
 <preferences xmlns="http://www.adito.de/2018/ao/Model" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" VERSION="3.1.0" xsi:schemaLocation="http://www.adito.de/2018/ao/Model adito://models/xsd/preferences/3.1.0">
   <name>_____PREFERENCES_PROJECT</name>
   <majorModelMode>DISTRIBUTED</majorModelMode>
-  <projectName>xRM-Basic5</projectName>
+  <projectName>xRM-Basic2019</projectName>
   <jditoMaxContentSize v="57671680" />
   <calendarCategoriesEvent>
     <entry>