Refactoring: more uses of SqlCondition

entity/Activity_entity/recordcontainers/db/conditionProcess.js

@@ -19,7 +19,7 @@ if (vars.exists("$param.RowId_param") && vars.get("$param.RowId_param") && vars.
                                                             from CONTACT \n\
                                                             where CONTACT.PERSON_ID = (select CONTACT.PERSON_ID from CONTACT", null, ")"));
     }
-    var activityLinkCond = SqlCondition.begin().and("ACTIVITYLINK.OBJECT_ROWID in ('" + rowIds.join(", ") + "')")
+    var activityLinkCond = SqlCondition.begin().andIn("ACTIVITYLINK.OBJECT_ROWID", rowIds)
                                                .andPrepareVars("ACTIVITYLINK.OBJECT_TYPE", "$param.ObjectId_param");
 
                                                             // TODO: more performant way than IN. Maybe a join??

entity/Communication_entity/recordcontainers/db/conditionProcess.js

@@ -12,6 +12,6 @@ if (vars.exists("$param.CommMediumIds_param"))
 {
     var mediumIds = JSON.parse(vars.getString("$param.CommMediumIds_param"));
     if(mediumIds.length > 0) 
-        cond.and("COMMUNICATION.MEDIUM_ID in ('" + mediumIds.join("', '") + "')");
+        cond.andIn("COMMUNICATION.MEDIUM_ID", mediumIds);
 }
-result.string(db.translateCondition([cond.toString("1 = 2"), cond.preparedValues]));
\ No newline at end of file
+result.string(db.translateCondition(cond.build("1 = 2")));
\ No newline at end of file

entity/DocumentTemplateLink_entity/entityfields/opendocument/onActionProcess.js

+import("Sql_lib");
 import("system.db");
 import("system.vars");
 import("system.neon");
 
-var fileInformation = db.array(db.ROW, "select ID, FILENAME from ASYS_BINARIES where ROW_ID = '" + vars.get("$field.DOCUMENTTEMPLATE_ID_CHILD") + "'", "_____SYSTEMALIAS");
+var fileInformation = db.array(db.ROW, SqlCondition.begin()
+    .andPrepareVars("ASYS_BINARIES.ROW_ID", "$field.DOCUMENTTEMPLATE_ID_CHILD")
+    .buildSql("select ID, FILENAME from ASYS_BINARIES"), "_____SYSTEMALIAS");
 var data = db.getBinaryContent(fileInformation[0], "_____SYSTEMALIAS");
 neon.download(data, fileInformation[1]);
 

entity/DocumentTemplate_entity/entityfields/textext/valueProcess.js

+import("Sql_lib");
 import("Document_lib");
 import("system.util");
 import("system.db");
@@ -11,7 +12,9 @@ if(vars.get("$field.KIND").trim() == "TEX" && vars.get("$field.BINDATA") == "" &
     
     if(fileExtension == "txt")
     {
-        var binaryId      = db.cell("select ID from ASYS_BINARIES where ROW_ID = '" + vars.get("$field.DOCUMENTTEMPLATEID") + "'", "_____SYSTEMALIAS");
+        var binaryId      = db.cell(SqlCondition.begin()
+            .andPrepareVars("ASYS_BINARIES.ROW_ID", "$field.DOCUMENTTEMPLATEID")
+            .buildSql("select ID from ASYS_BINARIES"), "_____SYSTEMALIAS");
         result.string(util.decodeBase64String(db.getBinaryContent(binaryId, "_____SYSTEMALIAS")));
     }
 }
\ No newline at end of file

entity/DocumentTemplate_entity/recordcontainers/db/onDBDelete.js

+import("Sql_lib");
 import("system.vars");
 import("system.db");
 
-var binaryId      = db.cell("select ID from ASYS_BINARIES where ROW_ID = '" + vars.get("$field.DOCUMENTTEMPLATEID") + "'", "_____SYSTEMALIAS");
+var binaryId      = db.cell(SqlCondition.begin()
+            .andPrepareVars("ASYS_BINARIES.ROW_ID", "$field.DOCUMENTTEMPLATEID")
+            .buildSql("select ID from ASYS_BINARIES"), "_____SYSTEMALIAS");
 
 db.deleteBinary(binaryId, "_____SYSTEMALIAS");
\ No newline at end of file

entity/DocumentTemplate_entity/recordcontainers/db/onDBUpdate.js

@@ -28,6 +28,8 @@ else if(rowdata["DOCUMENTTEMPLATE.KIND"].trim() == "TEX" && vars.get("$field.tex
 
 if(bindata != "" && filename != "")
 {
-    var binaryId      = db.cell("select ID from ASYS_BINARIES where ROW_ID = '" + vars.get("$local.uid") + "'", SqlUtils.getSystemAlias());
+    var binaryId      = db.cell(SqlCondition.begin()
+            .andPrepareVars("ASYS_BINARIES.ROW_ID", "$local.uid")
+            .buildSql("select ID from ASYS_BINARIES"), SqlUtils.getSystemAlias());
     db.updateBinary(binaryId, "", bindata, filename, "", "", SqlUtils.getSystemAlias());
 }
\ No newline at end of file

entity/Employee_entity/entityfields/email_address/dropDownProcess.js

@@ -10,7 +10,7 @@ if (contactId && (vars.get("$sys.recordstate") == neon.OPERATINGSTATE_EDIT || va
 {
     var sql = SqlCondition.begin()
         .andPrepare("COMMUNICATION.CONTACT_ID", contactId)
-        .and("COMMUNICATION.MEDIUM_ID in ('" + CommUtil.getMediumIdsByCategory("EMAIL").join("', '") + "')")
+        .andIn("COMMUNICATION.MEDIUM_ID", CommUtil.getMediumIdsByCategory("EMAIL"))
         .buildSql("select ADDR, ADDR from COMMUNICATION");
     
     var addresses = db.table(sql);

entity/ModuleTree_entity/recordcontainers/jdito/contentProcess.js

@@ -99,7 +99,9 @@ function queryChildrenElements (pContextName, pID) {
 function queryRootElement (pContextName, pID, pGetFirst) {
     var resultArray;
     if (pContextName === "Task") {
-        resultArray = db.array(db.ROW, "select TASKID, PARENT_ID, PARENT_CONTEXT, SUBJECT, DESCRIPTION from TASK where TASKID = '" + pID + "'");
+        resultArray = db.array(db.ROW, SqlCondition.begin()
+            .andPrepare("TASK.TASKID", pID)
+            .buildSql("select TASKID, PARENT_ID, PARENT_CONTEXT, SUBJECT, DESCRIPTION from TASK"));
         if (resultArray.length === 0) {
             return null;
         }
@@ -112,7 +114,9 @@ function queryRootElement (pContextName, pID, pGetFirst) {
         }
         return augmentData(resultArray, "Task");
     } else if (pContextName === "Activity") {
-        resultArray = db.array(db.ROW, "select ACTIVITYID, PARENT_ID, PARENT_CONTEXT, SUBJECT, INFO from ACTIVITY where ACTIVITYID = '" + pID +"'");
+        resultArray = db.array(db.ROW, SqlCondition.begin()
+            .andPrepare("ACTIVITY.ACTIVITYID", pID)
+            .buildSql("select ACTIVITYID, PARENT_ID, PARENT_CONTEXT, SUBJECT, INFO from ACTIVITY"));
         if (resultArray.length === 0) {
             return null;
         }
@@ -126,7 +130,9 @@ function queryRootElement (pContextName, pID, pGetFirst) {
         return augmentData(resultArray, "Activity");
     }
     else if (pContextName === "SupportTicket") {
-        resultArray = db.array(db.ROW, "select TICKETID, PARENT_ID, PARENT_CONTEXT, SUBJECT, DESCRIPTION from TICKET left join TASK on TASK_ID = TASKID where TICKETID = '" + pID +"'");
+        resultArray = db.array(db.ROW, SqlCondition.begin()
+            .andPrepare("TICKET.TICKETID", pID)
+            .buildSql("select TICKETID, PARENT_ID, PARENT_CONTEXT, SUBJECT, DESCRIPTION from TICKET left join TASK on TASK_ID = TASKID"));
         if (resultArray.length === 0) {
             return null;
         }