Skip to content
Snippets Groups Projects
Commit 1b4e55d3 authored by Johannes Hörmann's avatar Johannes Hörmann
Browse files

SqlCondition.translate instead of db.translateCondition(SqlCondition.build())

parent a51845ab
No related branches found
No related tags found
No related merge requests found
Showing
with 43 additions and 41 deletions
import("system.logging");
import("system.vars");
import("system.db");
import("system.result");
......@@ -6,5 +7,5 @@ import("Sql_lib");
var cond = SqlCondition.begin()
.andPrepareVars("ACTIVITYLINK.ACTIVITY_ID", "$param.ActivityId_param");
//TODO: use a preparedCondition when available #1030812 #1034026
result.string(db.translateCondition(cond.build("1 = 0")));
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate("1 = 0"));
\ No newline at end of file
......@@ -41,7 +41,7 @@ if (loadNothing)
}
else
{
//TODO: use a preparedCondition when available #1030812 #1034026
var resCond = db.translateCondition(cond.build("1 = 1"));
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
var resCond = cond.translate("1 = 1");
}
result.string(resCond);
\ No newline at end of file
......@@ -2,4 +2,5 @@ import("Sql_lib");
import("system.db");
import("system.result");
result.string(db.translateCondition(SqlCondition.begin().andPrepareVars("ADDRESS.CONTACT_ID", "$param.ContactId_param").build("1=1")));
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(SqlCondition.begin().andPrepareVars("ADDRESS.CONTACT_ID", "$param.ContactId_param").translate("1=1"));
......@@ -17,6 +17,5 @@ if (organisationId)
cond.orPrepare("ADDRESS.CONTACT_ID", organisationContactId);
}
cond = cond.build("1 = 2");
cond = db.translateCondition(cond);
result.string(cond);
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate("1 = 2"));
\ No newline at end of file
......@@ -30,4 +30,5 @@ var cond = SqlCondition.begin()
.andSqlCondition(conditionPrivateOrganisation)
.andPrepareIfSet("CONTACT.ORGANISATION_ID", orgContactId);
result.string(db.translateCondition(cond.build()));
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate());
\ No newline at end of file
......@@ -5,5 +5,5 @@ import("Sql_lib");
var cond = SqlCondition.begin()
.andPrepareVars("AB_APPOINTMENTLINK.APPOINTMENT_ID", "$param.AppointmentId_param")
//TODO: use a preparedCondition when available #1030812 #1034026
result.string(db.translateCondition(cond.build("1 = 1")));
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate("1 = 1"));
\ No newline at end of file
......@@ -14,7 +14,6 @@ import("system.entities")
var cond = SqlCondition.begin();
var appointmentUids;
var idscond;
if(vars.get("$local.idvalues") != null && vars.get("$local.idvalues") != "")
{
......@@ -27,9 +26,8 @@ else if(vars.getString("$param.LinkedAppointmentsFromDashlet_param"))
var contactid = EmployeeUtils.getCurrentContactId();
cond.andPrepareIfSet("AB_APPOINTMENTLINK.OBJECT_ROWID", contactid)
idscond = db.translateCondition(cond.build("1 = 1"));
appointmentUids = db.table("select APPOINTMENT_ID from AB_APPOINTMENTLINK where " + idscond);
appointmentUids = db.table(cond.buildSql("select APPOINTMENT_ID from AB_APPOINTMENTLINK"));
result.object(buildEntriesFromUids(appointmentUids));
}
......@@ -39,9 +37,8 @@ else if(vars.getString("$param.LinkedAppointmentsFromDashlet_param"))
else if(vars.getString("$param.LinkedObjectId_param") != undefined)
{
cond.andPrepareVars("AB_APPOINTMENTLINK.OBJECT_ROWID", "$param.LinkedObjectId_param")
idscond = db.translateCondition(cond.build("1 = 1"));
appointmentUids = db.table("select APPOINTMENT_ID from AB_APPOINTMENTLINK where " + idscond);
appointmentUids = db.table(cond.buildSql("select APPOINTMENT_ID from AB_APPOINTMENTLINK"));
result.object(buildEntriesFromUids(appointmentUids));
}
/**
......
......@@ -20,7 +20,6 @@ if (vars.exists("$param.Entry_param"))
*/
var cond = SqlCondition.begin();
cond.andPrepareIfSet("AB_APPOINTMENTLINK.APPOINTMENT_ID", entry[calendars.ID])
var idscond = db.translateCondition(cond.build("1 = 2"));
db.deleteData("AB_APPOINTMENTLINK", idscond);
db.deleteData("AB_APPOINTMENTLINK", cond.build("1 = 2"));
}
\ No newline at end of file
......@@ -2,6 +2,7 @@ import("Sql_lib");
import("system.db");
import("system.result");
result.string(db.translateCondition(SqlCondition.begin()
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(SqlCondition.begin()
.andPrepareVars("AB_ATTRIBUTEUSAGE.AB_ATTRIBUTE_ID", "$param.AttributeId_param")
.build("1=2")));
.translate("1=2"));
......@@ -4,5 +4,6 @@ import("Sql_lib");
var condition = SqlCondition.begin()
.andPrepareVars("BULKMAILRECIPIENT.BULKMAIL_ID", "$param.BulkMailId_param");
result.string(db.translateCondition(condition.build("1=1")));
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(condition.translate("1=1"));
\ No newline at end of file
......@@ -19,4 +19,5 @@ else
cond.and("CAMPAIGNCOST.CAMPAIGNSTEP_ID is null");
}
result.string(db.translateCondition(cond.build("1=2")));
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate("1=2"));
\ No newline at end of file
......@@ -8,5 +8,5 @@ var cond = SqlCondition.begin()
cond.andPrepareIfSet("CAMPAIGNSTEP.SORTING", vars.getString("$param.maxSort_param"), "# <= ?");
result.string(db.translateCondition(cond.build("1=1")));
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate("1=1"));
\ No newline at end of file
......@@ -6,6 +6,6 @@ import("system.vars");
if(vars.get("$param.ShowOnlyCurrentUsersCampaigns_param") == 'true')
{
//TODO: use a preparedCondition when available #1030812 #1034026
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string("CAMPAIGN.EMPLOYEE_CONTACT_ID = '" + EmployeeUtils.getCurrentContactId() + "'");
}
\ No newline at end of file
......@@ -37,8 +37,8 @@ if (vars.exists("$local.filter") && vars.get("$local.filter"))
var masking = new SqlMaskingUtils();
result.object(db.table(cond.buildSql("select CLASSIFICATIONTYPEID, CLASSIFICATIONID, CLASSIFICATIONGROUP, CLASSIFICATIONSCORE_ID, CLASSIFICATIONTYPEID, CLASSIFICATIONTYPE_ID, OBJECT_TYPE, OBJECT_ROWID, SCORETYPE, CLASSIFICATIONTYPE.CLASSIFICATIONTYPE from CLASSIFICATION \n\
right join CLASSIFICATIONTYPE on " + db.translateCondition(SqlCondition.begin()
right join CLASSIFICATIONTYPE on " + SqlCondition.begin()
.and("CLASSIFICATIONTYPE_ID = CLASSIFICATIONTYPEID")
.andPrepareVars("CLASSIFICATION.OBJECT_TYPE", "$param.ObjectType_param")
.andPrepareVars("CLASSIFICATION.OBJECT_ROWID", "$param.ObjectRowid_param").build()), "1=1", "order by CLASSIFICATIONGROUP asc"))
.andPrepareVars("CLASSIFICATION.OBJECT_ROWID", "$param.ObjectRowid_param").translate(), "1=1", "order by CLASSIFICATIONGROUP asc"))
);
\ No newline at end of file
......@@ -3,6 +3,7 @@ import("Sql_lib");
import("system.db");
import("system.result");
result.string(db.translateCondition(SqlCondition.begin()
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(SqlCondition.begin()
.andPrepareVars("CLASSIFICATIONSCORE.CLASSIFICATIONTYPE_ID", "$param.ClassificationTypeId_param")
.build("1=2")));
\ No newline at end of file
.translate("1=2"));
\ No newline at end of file
......@@ -49,10 +49,10 @@ if (vars.exists("$local.filter") && vars.get("$local.filter"))
var masking = new SqlMaskingUtils();
result.object(db.table(cond.buildSql("select case when CLASSIFICATIONID is not null then " + masking.concat(["'C,'", "CLASSIFICATIONID"], "", false) + " else " + masking.concat(["'T,'", "CLASSIFICATIONTYPEID"], "", false) + " end, CLASSIFICATIONID, CLASSIFICATIONGROUP, CLASSIFICATIONSCORE_ID, CLASSIFICATIONTYPEID, CLASSIFICATIONTYPE_ID, OBJECT_TYPE, OBJECT_ROWID, SCORETYPE, CLASSIFICATIONTYPE.CLASSIFICATIONTYPE from CLASSIFICATION \n\
right join CLASSIFICATIONTYPE on " + db.translateCondition(SqlCondition.begin()
right join CLASSIFICATIONTYPE on " + SqlCondition.begin()
.and("CLASSIFICATIONTYPE_ID = CLASSIFICATIONTYPEID")
.andPrepareVars("CLASSIFICATION.OBJECT_TYPE", "$param.ObjectType_param")
.andPrepareVars("CLASSIFICATION.OBJECT_ROWID", "$param.ObjectRowid_param").build()), "1=2", "order by CLASSIFICATIONGROUP asc"))
.andPrepareVars("CLASSIFICATION.OBJECT_ROWID", "$param.ObjectRowid_param").translate(), "1=2", "order by CLASSIFICATIONGROUP asc"))
.map(function(pRow)
{
pRow.push(scores);
......
......@@ -5,5 +5,5 @@ import("Sql_lib");
var cond = new SqlCondition();
cond.andPrepareVars("COMMRESTRICTION.CONTACT_ID", "$param.ContactId_param");
//TODO: use a preparedCondition when available #1030812 #1034026
result.string(db.translateCondition(cond.build("1 = 1")));
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate("1 = 1"));
\ No newline at end of file
......@@ -14,4 +14,5 @@ if (vars.exists("$param.CommMediumIds_param"))
if(mediumIds.length > 0)
cond.andIn("COMMUNICATION.MEDIUM_ID", mediumIds);
}
result.string(db.translateCondition(cond.build("1 = 2")));
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate("1 = 2"));
\ No newline at end of file
......@@ -6,6 +6,5 @@ var cond = new SqlCondition();
cond.andPrepareVars("COMPETITION.OBJECT_ROWID", "$param.ObjectRowId_param"),
cond.andPrepareVars("COMPETITION.OBJECT_TYPE", "$param.ObjectType_param");
//TODO: use a preparedCondition when available #1030812 #1034026
result.string(db.translateCondition(cond.build("1 = 1")));
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate("1 = 1"));
......@@ -7,5 +7,5 @@ var cond = new SqlCondition();
cond.andPrepareVars("CONTACT.CONTACTID", "$param.OwnContactId_param", "# != ?");
cond.andPrepareVars("CONTACT.PERSON_ID", "$param.PersonId_param");
//TODO: use a preparedCondition when available #1030812 #1034026
result.string(db.translateCondition(cond.build("1 = 2")));
\ No newline at end of file
//TODO: use a preparedCondition (.build instead of .translate) when available #1030812 #1034026
result.string(cond.translate("1 = 2"));
\ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment